From: Dan Carpenter Date: Thu, 12 Jul 2018 12:23:45 +0000 (+0300) Subject: qlogic: check kstrtoul() for errors X-Git-Tag: v4.18-rc6~28^2~39 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5fc853cc01c68f84984ecc2d5fd777ecad78240f;p=users%2Fdwmw2%2Flinux.git qlogic: check kstrtoul() for errors We accidentally left out the error handling for kstrtoul(). Fixes: a520030e326a ("qlcnic: Implement flash sysfs callback for 83xx adapter") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c index 891f03a7a33dc..8d7b9bb910f2a 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c @@ -1128,6 +1128,8 @@ static ssize_t qlcnic_83xx_sysfs_flash_write_handler(struct file *filp, struct qlcnic_adapter *adapter = dev_get_drvdata(dev); ret = kstrtoul(buf, 16, &data); + if (ret) + return ret; switch (data) { case QLC_83XX_FLASH_SECTOR_ERASE_CMD: