From: Joe Hattori Date: Thu, 27 Jun 2024 06:31:09 +0000 (+0900) Subject: char: tpm: Fix possible memory leak in tpm_bios_measurements_open() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5d8e2971e817bb64225fc0b6327a78752f58a9aa;p=users%2Fjedix%2Flinux-maple.git char: tpm: Fix possible memory leak in tpm_bios_measurements_open() In tpm_bios_measurements_open(), get_device() is called on the device embedded in struct tpm_chip. In the error path, however, put_device() is not called. This results in a reference count leak, which prevents the device from being properly released. This commit makes sure to call put_device() when the seq_open() call fails. Cc: stable@vger.kernel.org # +v4.18 Fixes: 9b01b5356629 ("tpm: Move shared eventlog functions to common.c") Signed-off-by: Joe Hattori Signed-off-by: Jarkko Sakkinen --- diff --git a/drivers/char/tpm/eventlog/common.c b/drivers/char/tpm/eventlog/common.c index 639c3f395a5af..4c0bbba64ee50 100644 --- a/drivers/char/tpm/eventlog/common.c +++ b/drivers/char/tpm/eventlog/common.c @@ -47,6 +47,8 @@ static int tpm_bios_measurements_open(struct inode *inode, if (!err) { seq = file->private_data; seq->private = chip; + } else { + put_device(&chip->dev); } return err;