From: Karsten Weiss <k.weiss@science-computing.de>
Date: Tue, 6 Dec 2016 17:40:28 +0000 (-0500)
Subject: Fix suffix shift overflow
X-Git-Tag: v1.1~15
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5c3adcdaa61c16050c4631579bcf4c09a5d30845;p=users%2Fsagi%2Fnvme-cli.git

Fix suffix shift overflow

From: Karsten Weiss <k.weiss@science-computing.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
---

diff --git a/suffix.c b/suffix.c
index 086cb883..590db832 100644
--- a/suffix.c
+++ b/suffix.c
@@ -87,7 +87,7 @@ const char *suffix_binary_get(long long *value)
 	for (s = binary_suffixes; s->shift != 0; s++) {
 		if (llabs(*value) >= (1LL << s->shift)) {
 			*value =
-			    (*value + (1 << (s->shift - 1))) / (1 << s->shift);
+			    (*value + (1LL << (s->shift - 1))) / (1LL << s->shift);
 			return s->suffix;
 		}
 	}
@@ -101,7 +101,7 @@ const char *suffix_dbinary_get(double *value)
 
 	for (s = binary_suffixes; s->shift != 0; s++) {
 		if (fabs(*value) >= (1LL << s->shift)) {
-			*value = *value / (1 << s->shift);
+			*value = *value / (1LL << s->shift);
 			return s->suffix;
 		}
 	}