From: Yazen Ghannam Date: Fri, 8 May 2020 14:51:29 +0000 (+0000) Subject: rasdaemon: Fix "ignoring return value" build warning. X-Git-Tag: v0.6.7~32 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5b354684dfcd4e0ff1c4ef3a1914ff116c42cccc;p=users%2Fmchehab%2Frasdaemon.git rasdaemon: Fix "ignoring return value" build warning. The following build warning is given: ras-diskerror-handler.c: In function ras_diskerror_event_handler: ras-diskerror-handler.c:98:2: warning: ignoring return value of asprintf, declared with attribute warn_unused_result [-Wunused-result] asprintf(&ev.dev, "%u:%u", major(dev), minor(dev)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Check the return value of asprintf() to avoid the warning. Signed-off-by: Yazen Ghannam Signed-off-by: Mauro Carvalho Chehab --- diff --git a/ras-diskerror-handler.c b/ras-diskerror-handler.c index 68c0c77..b16319f 100644 --- a/ras-diskerror-handler.c +++ b/ras-diskerror-handler.c @@ -95,7 +95,8 @@ int ras_diskerror_event_handler(struct trace_seq *s, if (pevent_get_field_val(s, event, "dev", record, &val, 1) < 0) return -1; dev = (dev_t)val; - asprintf(&ev.dev, "%u:%u", major(dev), minor(dev)); + if (asprintf(&ev.dev, "%u:%u", major(dev), minor(dev)) < 0) + return -1; if (pevent_get_field_val(s, event, "sector", record, &val, 1) < 0) return -1;