From: Colin Ian King Date: Mon, 6 Jan 2020 12:05:58 +0000 (+0000) Subject: power: avs: fix uninitialized error return on failed cpr_read_fuse_uV() call X-Git-Tag: v5.6-rc1~192^2~1^5~1 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5aa0c467519ccd862678a15885026660c271b5b0;p=linux.git power: avs: fix uninitialized error return on failed cpr_read_fuse_uV() call Currently when the call cpr_read_fuse_uV returns an error the value in the uninitialized variable ret is returned. Fix this by instread returning the error value in the variable uV. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)") Signed-off-by: Colin Ian King Reviewed-by: Bjorn Andersson Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c index 9247f53550b3..0321729431a5 100644 --- a/drivers/power/avs/qcom-cpr.c +++ b/drivers/power/avs/qcom-cpr.c @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv) uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage, step_volt, drv); if (uV < 0) - return ret; + return uV; fuse->min_uV = fdata->min_uV; fuse->max_uV = fdata->max_uV;