From: Florian Fainelli Date: Mon, 12 Mar 2018 23:00:40 +0000 (-0700) Subject: net: dsa: Fix dsa_is_user_port() test inversion X-Git-Tag: v4.16-rc7~23^2~51 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5a9f8df68ee6927f21dd3f2c75c16feb8b53a9e8;p=users%2Fwilly%2Fxarray.git net: dsa: Fix dsa_is_user_port() test inversion During the conversion to dsa_is_user_port(), a condition ended up being reversed, which would prevent the creation of any user port when using the legacy binding and/or platform data, fix that. Fixes: 4a5b85ffe2a0 ("net: dsa: use dsa_is_user_port everywhere") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/net/dsa/legacy.c b/net/dsa/legacy.c index cb54b81d0bd9..42a7b85b84e1 100644 --- a/net/dsa/legacy.c +++ b/net/dsa/legacy.c @@ -194,7 +194,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, ds->ports[i].dn = cd->port_dn[i]; ds->ports[i].cpu_dp = dst->cpu_dp; - if (dsa_is_user_port(ds, i)) + if (!dsa_is_user_port(ds, i)) continue; ret = dsa_slave_create(&ds->ports[i]);