From: Himanshu Madhani Date: Tue, 15 Mar 2016 05:47:37 +0000 (-0700) Subject: target: Fix target_release_cmd_kref shutdown comp leak X-Git-Tag: v4.1.12-92~150^2~27 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5a570614ce0c83fce40d508e861de1ad3dd046a3;p=users%2Fjedix%2Flinux-maple.git target: Fix target_release_cmd_kref shutdown comp leak Orabug: 23331148 [ Upstream commit 5e47f1985d7107331c3f64fb3ec83d66fd73577e ] This patch fixes an active I/O shutdown bug for fabric drivers using target_wait_for_sess_cmds(), where se_cmd descriptor shutdown would result in hung tasks waiting indefinitely for se_cmd->cmd_wait_comp to complete(). To address this bug, drop the incorrect list_del_init() usage in target_wait_for_sess_cmds() and always complete() during se_cmd target_release_cmd_kref() put, in order to let caller invoke the final fabric release callback into se_cmd->se_tfo->release_cmd() code. Reported-by: Himanshu Madhani Tested-by: Himanshu Madhani Signed-off-by: Himanshu Madhani Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger Signed-off-by: Sasha Levin Signed-off-by: Dan Duval (cherry picked from commit b90311472f0dc0aa7a7223c1220db47ce4db5447) Conflict: drivers/target/target_core_transport.c --- diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 3881504b40d83..d1a022ff74c13 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2577,8 +2577,6 @@ void target_wait_for_sess_cmds(struct se_session *se_sess) list_for_each_entry_safe(se_cmd, tmp_cmd, &se_sess->sess_wait_list, se_cmd_list) { - list_del(&se_cmd->se_cmd_list); - pr_debug("Waiting for se_cmd: %p t_state: %d, fabric state:" " %d\n", se_cmd, se_cmd->t_state, se_cmd->se_tfo->get_cmd_state(se_cmd));