From: Jia-Ju Bai Date: Mon, 23 Jul 2018 14:29:56 +0000 (+0800) Subject: gpu: drm: amdgpu: Replace mdelay with msleep in cik_pcie_gen3_enable() X-Git-Tag: for-linus-4.19b-rc1b-tag~59^2~14^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=586092ab4b768b01b3184d9a2541e2cf9a8d9740;p=users%2Fdwmw2%2Flinux.git gpu: drm: amdgpu: Replace mdelay with msleep in cik_pcie_gen3_enable() cik_pcie_gen3_enable() is only called by cik_common_hw_init(), which is never called in atomic context. cik_pcie_gen3_enable() calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/cik.c b/drivers/gpu/drm/amd/amdgpu/cik.c index 702e257a483ff..78ab939ae5d86 100644 --- a/drivers/gpu/drm/amd/amdgpu/cik.c +++ b/drivers/gpu/drm/amd/amdgpu/cik.c @@ -1476,7 +1476,7 @@ static void cik_pcie_gen3_enable(struct amdgpu_device *adev) tmp |= PCIE_LC_CNTL4__LC_REDO_EQ_MASK; WREG32_PCIE(ixPCIE_LC_CNTL4, tmp); - mdelay(100); + msleep(100); /* linkctl */ pci_read_config_word(root, bridge_pos + PCI_EXP_LNKCTL, &tmp16);