From: James Smart <jsmart2021@gmail.com>
Date: Tue, 7 Jan 2020 17:02:57 +0000 (-0700)
Subject: Fix systemd service script use of CONNECT_ARGS env var
X-Git-Tag: v1.10~5
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=57315578d9e500dae5143dbda607dcadc933c545;p=users%2Fhch%2Fnvme-cli.git

Fix systemd service script use of CONNECT_ARGS env var

In testing, some environments are not properly expanding CONNECT_ARGS.

Change systemd service file use of CONNECT_ARGS to be encapsulated by
apostrophes and parens.

Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---

diff --git a/nvmf-autoconnect/systemd/nvmf-connect@.service b/nvmf-autoconnect/systemd/nvmf-connect@.service
index 10fb3aa..c60f146 100644
--- a/nvmf-autoconnect/systemd/nvmf-connect@.service
+++ b/nvmf-autoconnect/systemd/nvmf-connect@.service
@@ -11,4 +11,4 @@ Requires=nvmf-connect.target
 [Service]
 Type=simple
 Environment="CONNECT_ARGS=%i"
-ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e $CONNECT_ARGS`"
+ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e '${CONNECT_ARGS}'`"