From: Amir Goldstein Date: Thu, 8 Dec 2016 10:52:20 +0000 (+0200) Subject: common: implement _require_xfs_io_command "open" X-Git-Tag: v2022.05.01~2277 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=53d31765f607735a055dad7423924584b347aee8;p=users%2Fhch%2Fxfstests-dev.git common: implement _require_xfs_io_command "open" -c "open $f" is broken in xfs_io <= 4.8. Using it results in an endless loop and xfs_io exists with error EMFILE. A fix for that bug makes "open" a 'one shot' command. Along with this fix, a new -C flag was introduced to explicitly request to execute a one shot command. Check for -C flag support as an indication that -c "open $f" is not broken. Signed-off-by: Amir Goldstein Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/common/rc b/common/rc index 6d9694f74..2639fbdab 100644 --- a/common/rc +++ b/common/rc @@ -1758,6 +1758,14 @@ _require_xfs_io_command() echo $testio | egrep -q "Inappropriate ioctl" && \ _notrun "xfs_io $command support is missing" ;; + "open") + # -c "open $f" is broken in xfs_io <= 4.8. Along with the fix, + # a new -C flag was introduced to execute one shot commands. + # Check for -C flag support as an indication for the bug fix. + testio=`$XFS_IO_PROG -F -f -C "open $testfile" $testfile 2>&1` + echo $testio | egrep -q "invalid option" && \ + _notrun "xfs_io $command support is missing" + ;; *) testio=`$XFS_IO_PROG -c "$command help" 2>&1` esac