From: Michał Mirosław Date: Fri, 13 Nov 2020 00:20:28 +0000 (+0100) Subject: regulator: workaround self-referent regulators X-Git-Tag: v4.14.209~8 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=52ad1338d3b6c3adf03f1c1930b0e973f500f92d;p=users%2Fdwmw2%2Flinux.git regulator: workaround self-referent regulators commit f5c042b23f7429e5c2ac987b01a31c69059a978b upstream. Workaround regulators whose supply name happens to be the same as its own name. This fixes boards that used to work before the early supply resolving was removed. The error message is left in place so that offending drivers can be detected. Fixes: aea6cb99703e ("regulator: resolve supply after creating regulator") Cc: stable@vger.kernel.org Reported-by: Ahmad Fatoum Signed-off-by: Michał Mirosław Tested-by: Ahmad Fatoum # stpmic1 Link: https://lore.kernel.org/r/d703acde2a93100c3c7a81059d716c50ad1b1f52.1605226675.git.mirq-linux@rere.qmqm.pl Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a23ae0b128f28..2c4439f3e12e6 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1547,7 +1547,10 @@ static int regulator_resolve_supply(struct regulator_dev *rdev) if (r == rdev) { dev_err(dev, "Supply for %s (%s) resolved to itself\n", rdev->desc->name, rdev->supply_name); - return -EINVAL; + if (!have_full_constraints()) + return -EINVAL; + r = dummy_regulator_rdev; + get_device(&r->dev); } /*