From: Guangyu Sun Date: Thu, 24 Oct 2013 17:56:21 +0000 (+0000) Subject: xfstest generic/280: wait for setquota to finish before umount X-Git-Tag: v2022.05.01~3311 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=527eeb43e5c7cfd642d81bc3c12e746d2a3733ff;p=users%2Fhch%2Fxfstests-dev.git xfstest generic/280: wait for setquota to finish before umount While running xfstest 280, we occasionally got such error: setquota: Cannot set quota for user 0 from kernel on /dev/mapper/xfstests-disk1: No such device setquota: Cannot write quota for 0 on /dev/mapper/xfstests-disk1: No such device setquota calls syscall quotactl, and the kernel will wait for the filesystem to unfreeze and then performs command. Then kernel will double check if the device is still mounted. If not, an ENODEV will be thrown. While in the testcase, unfreeze and umount might be so close that the device got umounted before quotactl is performed. Reported-by: Stanislav Kholmanskikh Signed-off-by: Guangyu Sun Reviewed-by: Eric Sandeen Signed-off-by: Rich Johnston --- diff --git a/tests/generic/280 b/tests/generic/280 index 5491a6b2f..815a2c568 100755 --- a/tests/generic/280 +++ b/tests/generic/280 @@ -63,6 +63,7 @@ xfs_freeze -f $SCRATCH_MNT setquota -u root 1 2 3 4 $SCRATCH_MNT & sleep 1 xfs_freeze -u $SCRATCH_MNT +sleep 1 umount $SCRATCH_DEV # Failure comes in the form of a deadlock.