From: Chen-Yu Tsai <wens@csie.org>
Date: Tue, 22 Dec 2015 04:27:35 +0000 (-0200)
Subject: [media] rc: sunxi-cir: Initialize the spinlock properly
X-Git-Tag: v4.1.12-92~150^2~323
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=524cf7cc3187b1497b1fdd0b93218b8244f7e209;p=users%2Fjedix%2Flinux-maple.git

[media] rc: sunxi-cir: Initialize the spinlock properly

Orabug: 23330603

[ Upstream commit 768acf46e1320d6c41ed1b7c4952bab41c1cde79 ]

The driver allocates the spinlock but fails to initialize it correctly.
The kernel reports a BUG indicating bad spinlock magic when spinlock
debugging is enabled.

Call spin_lock_init() on it to initialize it correctly.

Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver")

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 33c7c20d62a7916522628fbb45bb65cbc0b9f899)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
---

diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
index 7830aef3db459..40f77685cc4a2 100644
--- a/drivers/media/rc/sunxi-cir.c
+++ b/drivers/media/rc/sunxi-cir.c
@@ -153,6 +153,8 @@ static int sunxi_ir_probe(struct platform_device *pdev)
 	if (!ir)
 		return -ENOMEM;
 
+	spin_lock_init(&ir->ir_lock);
+
 	if (of_device_is_compatible(dn, "allwinner,sun5i-a13-ir"))
 		ir->fifo_size = 64;
 	else