From: Thorsten Blum Date: Thu, 28 Aug 2025 16:26:24 +0000 (+0200) Subject: usb: storage: realtek_cr: Simplify residue calculation in rts51x_bulk_transport() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=5195edb359855d9a6460f19b7c3915a8611fceed;p=users%2Fhch%2Fmisc.git usb: storage: realtek_cr: Simplify residue calculation in rts51x_bulk_transport() Simplify the calculation of 'residue' in rts51x_bulk_transport() and avoid unnecessarily reassigning 'residue' to itself. Acked-by: Alan Stern Signed-off-by: Thorsten Blum Link: https://lore.kernel.org/r/20250828162623.4840-3-thorsten.blum@linux.dev Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index cb5bbb19060e..3cc243956fd4 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -260,8 +260,8 @@ static int rts51x_bulk_transport(struct us_data *us, u8 lun, * try to compute the actual residue, based on how much data * was really transferred and what the device tells us */ - if (residue) - residue = residue < buf_len ? residue : buf_len; + if (residue > buf_len) + residue = buf_len; if (act_len) *act_len = buf_len - residue;