From: Dan Carpenter Date: Tue, 26 Jan 2016 09:24:25 +0000 (+0300) Subject: intel_scu_ipcutil: underflow in scu_reg_access() X-Git-Tag: v4.1.12-92~150^2~231 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=505aa9e1c76bf06a9ae08d6bf869821e63ddfaf8;p=users%2Fjedix%2Flinux-maple.git intel_scu_ipcutil: underflow in scu_reg_access() Orabug: 23330826 [ Upstream commit b1d353ad3d5835b16724653b33c05124e1b5acf1 ] "count" is controlled by the user and it can be negative. Let's prevent that by making it unsigned. You have to have CAP_SYS_RAWIO to call this function so the bug is not as serious as it could be. Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc') Signed-off-by: Dan Carpenter Cc: stable@vger.kernel.org Signed-off-by: Darren Hart Signed-off-by: Sasha Levin (cherry picked from commit abd62631a46c8a27fc607ea5525d3034e8d69781) Signed-off-by: Dan Duval --- diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index 02bc5a6343c3..aa454241489c 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -49,7 +49,7 @@ struct scu_ipc_data { static int scu_reg_access(u32 cmd, struct scu_ipc_data *data) { - int count = data->count; + unsigned int count = data->count; if (count == 0 || count == 3 || count > 4) return -EINVAL;