From: Michael Rubin Date: Thu, 17 Apr 2025 00:32:43 +0000 (+0000) Subject: staging: gpib: ni_usb: struct gpib_interface X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4f7c2391168f657209b7321a889a9e6428892708;p=users%2Fwilly%2Flinux.git staging: gpib: ni_usb: struct gpib_interface Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin Link: https://lore.kernel.org/r/20250417003246.84445-16-matchstick@neverthere.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c index 588bb3da9832..d5b281fa8b37 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -2373,7 +2373,7 @@ static void ni_usb_detach(struct gpib_board *board) mutex_unlock(&ni_usb_hotplug_lock); } -static gpib_interface_t ni_usb_gpib_interface = { +static struct gpib_interface ni_usb_gpib_interface = { .name = "ni_usb_b", .attach = ni_usb_attach, .detach = ni_usb_detach,