From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 9 Sep 2020 09:45:28 +0000 (+0300)
Subject: crypto: sa2ul - Fix pm_runtime_get_sync() error checking
X-Git-Tag: v5.9.2~605
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4ece2c1f2b762817748a7c40867492836dd58f5b;p=users%2Fdwmw2%2Flinux.git

crypto: sa2ul - Fix pm_runtime_get_sync() error checking

[ Upstream commit 2baace5feb86c6916221911f391f11fcd8e1a259 ]

The pm_runtime_get_sync() function returns either 0 or 1 on success but
this code treats a return of 1 as a failure.

Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index ff8bbdb4d235d..039579b7cc818 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -2331,7 +2331,7 @@ static int sa_ul_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(dev);
 	ret = pm_runtime_get_sync(dev);
-	if (ret) {
+	if (ret < 0) {
 		dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__,
 			ret);
 		return ret;