From: Christian König Date: Mon, 18 Oct 2021 19:27:55 +0000 (+0200) Subject: drm/scheduler: fix drm_sched_job_add_implicit_dependencies X-Git-Tag: howlett/maple/20220722_2~1779^2~2^2~2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4eaf02d6076c138d929f98b4c8afc4fef6d2915d;p=users%2Fjedix%2Flinux-maple.git drm/scheduler: fix drm_sched_job_add_implicit_dependencies Trivial fix since we now need to grab a reference to the fence we have added. Previously the dma_resv function where doing that for us. Signed-off-by: Christian König Fixes: 9c2ba265352a ("drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2") Link: https://patchwork.freedesktop.org/patch/msgid/20211019112706.27769-1-christian.koenig@amd.com Reviewed-by: Daniel Vetter Reported-by: Nicolas Frattaroli References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/ Tested-by: Nicolas Frattaroli Tested-by: Yassine Oudjana --- diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 5bc5f775abe1..94fe51b3caa2 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job, ret = drm_sched_job_add_dependency(job, fence); if (ret) return ret; + + /* Make sure to grab an additional ref on the added fence */ + dma_fence_get(fence); } return 0; }