From: Vlad Buslov Date: Wed, 7 Apr 2021 15:36:02 +0000 (+0300) Subject: Revert "net: sched: bump refcount for new action in ACT replace mode" X-Git-Tag: howlett/maple/20220722_2~3429^2~10^2~2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4ba86128ba077fbb7d86516ae24ed642e6c3adef;p=users%2Fjedix%2Flinux-maple.git Revert "net: sched: bump refcount for new action in ACT replace mode" This reverts commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149. Following commit in series fixes the issue without introducing regression in error rollback of tcf_action_destroy(). Signed-off-by: Vlad Buslov Signed-off-by: David S. Miller --- diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 43cceb924976..b919826939e0 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -1042,9 +1042,6 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp, if (err != ACT_P_CREATED) module_put(a_o->owner); - if (!bind && ovr && err == ACT_P_CREATED) - refcount_set(&a->tcfa_refcnt, 2); - return a; err_out: