From: Darrick J. Wong <darrick.wong@oracle.com>
Date: Fri, 27 Oct 2017 00:43:12 +0000 (-0700)
Subject: common/fuzzy: online re-scrub should not preen
X-Git-Tag: v2022.05.01~1812
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4b69106b60cbb41ed4ad94e98227d2a911ed83a6;p=users%2Fhch%2Fxfstests-dev.git

common/fuzzy: online re-scrub should not preen

When we're doing the second online scrub (to figure out if the
repair did any good) we shouldn't let that second scrub preen the
filesystem in any way. If scrub finds things it can't/won't preen
that turns into a nonzero return code which gets reported
(incorrectly) as a failure.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
---

diff --git a/common/fuzzy b/common/fuzzy
index 8453c29fc..86492687b 100644
--- a/common/fuzzy
+++ b/common/fuzzy
@@ -274,7 +274,7 @@ __scratch_xfs_fuzz_field_test() {
 		# which scrub doesn't know how to fix.
 		echo "++ Online scrub"
 		if [ "$1" != "sb 0" ]; then
-			_scratch_scrub -e continue 2>&1
+			_scratch_scrub -n -e continue 2>&1
 			res=$?
 			test $res -ne 0 && \
 				(>&2 echo "online re-scrub ($res) with ${field} = ${fuzzverb}.")