From: Omar Sandoval <osandov@fb.com>
Date: Mon, 25 Jun 2018 19:21:23 +0000 (-0700)
Subject: Makefile: reenable some shellcheck warnings
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4a869e44265e1c82a34c94046f265da5d89fb13e;p=users%2Fsagi%2Fblktests.git

Makefile: reenable some shellcheck warnings

Bart's patches fixed several shellcheck warnings which we previously
disabled. Reenable them.

Signed-off-by: Omar Sandoval <osandov@fb.com>
---

diff --git a/Makefile b/Makefile
index 14ba834..47531e5 100644
--- a/Makefile
+++ b/Makefile
@@ -4,18 +4,11 @@ all:
 clean:
 	$(MAKE) -C src clean
 
-# SC1090: "Can't follow non-constant source". We use variable sources all over
-# the place.
 # SC2034: "VARIABLE appears unused". All test scripts use this for the test
 # metadata, and many helper functions define global variables.
 # SC2119: "Use foo "$@" if function's $1 should mean script's $1". False
 # positives on helpers like _init_scsi_debug.
-# SC2154: "VARIABLE is referenced but not assigned". False positives on
-# TEST_RUN[foo]=bar.
-# SC2209: "Use var=$(command) to assign output (or quote to assign string)".
-# Warns about DMESG_FILTER=cat, which is not going to confuse anyone who knows
-# how to write shell scripts.
-SHELLCHECK_EXCLUDE := SC1090,SC2034,SC2119,SC2154,SC2209
+SHELLCHECK_EXCLUDE := SC2034,SC2119
 
 check:
 	shellcheck -x -e $(SHELLCHECK_EXCLUDE) -f gcc check new common/* tests/*/[0-9]*[0-9]