From: Richard Henderson <richard.henderson@linaro.org>
Date: Fri, 4 Oct 2024 17:21:59 +0000 (-0700)
Subject: accel/tcg: Assert noreturn from write-only page for atomics
X-Git-Tag: pull-vmclock-20250108~119^2~19
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=49d1866a6e53b84fd0aceced39ee3d01eb77e813;p=users%2Fdwmw2%2Fqemu.git

accel/tcg: Assert noreturn from write-only page for atomics

There should be no "just in case"; the page is already
in the tlb, and known to be not readable.

Reviewed-by: Helge Deller <deller@gmx.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 117b516739..fd6459b695 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1852,10 +1852,9 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr addr, MemOpIdx oi,
         /*
          * Since we don't support reads and writes to different
          * addresses, and we do have the proper page loaded for
-         * write, this shouldn't ever return.  But just in case,
-         * handle via stop-the-world.
+         * write, this shouldn't ever return.
          */
-        goto stop_the_world;
+        g_assert_not_reached();
     }
     /* Collect tlb flags for read. */
     tlb_addr |= tlbe->addr_read;