From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: Fri, 29 Nov 2024 16:47:47 +0000 (+0900)
Subject: tracing/eprobe: Fix to release eprobe when failed to add dyn_event
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=494b332064c0ce2f7392fa92632bc50191c1b517;p=users%2Fdwmw2%2Flinux.git

tracing/eprobe: Fix to release eprobe when failed to add dyn_event

Fix eprobe event to unregister event call and release eprobe when it fails
to add dynamic event correctly.

Link: https://lore.kernel.org/all/173289886698.73724.1959899350183686006.stgit@devnote2/

Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace events")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---

diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index ebda68ee9abff..be8be0c1aaf0f 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -963,6 +963,11 @@ static int __trace_eprobe_create(int argc, const char *argv[])
 		goto error;
 	}
 	ret = dyn_event_add(&ep->devent, &ep->tp.event->call);
+	if (ret < 0) {
+		trace_probe_unregister_event_call(&ep->tp);
+		mutex_unlock(&event_mutex);
+		goto error;
+	}
 	mutex_unlock(&event_mutex);
 	return ret;
 parse_error: