From: Konrad Rzeszutek Wilk Date: Wed, 23 May 2012 16:55:38 +0000 (-0400) Subject: xen/hvc: Fix error cases around HVM_PARAM_CONSOLE_PFN X-Git-Tag: v2.6.39-400.9.0~423^2~24^2~1 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=48cc0f5a80fd7b987bb682e2ba3618498f7489c5;p=users%2Fjedix%2Flinux-maple.git xen/hvc: Fix error cases around HVM_PARAM_CONSOLE_PFN We weren't resetting the parameter to be passed in to a known default. Nor were we checking the return value of hvm_get_parameter. CC: stable@kernel.org Signed-off-by: Konrad Rzeszutek Wilk --- diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 346b87fd1afa..6014208d71b0 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -219,7 +219,8 @@ static int xen_hvm_console_init(void) if (r < 0) goto err; info->evtchn = v; - hvm_get_parameter(HVM_PARAM_CONSOLE_PFN, &v); + v = 0; + r = hvm_get_parameter(HVM_PARAM_CONSOLE_PFN, &v); if (r < 0) goto err; mfn = v;