From: Cédric Le Goater <clg@kaod.org>
Date: Thu, 9 May 2019 12:33:44 +0000 (+0200)
Subject: KVM: PPC: Book3S: Remove useless checks in 'release' method of KVM device
X-Git-Tag: v5.2-rc1~17^2~2^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4894fbcce856635c9ab79f44e50826e86bb92110;p=users%2Fhch%2Fmisc.git

KVM: PPC: Book3S: Remove useless checks in 'release' method of KVM device

There is no need to test for the device pointer validity when releasing
a KVM device. The file descriptor should identify it safely.

Fixes: 2bde9b3ec8bd ("KVM: Introduce a 'release' method for KVM devices")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
---

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index ea2619d5ca98..37149433c07a 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2938,12 +2938,6 @@ static int kvm_device_release(struct inode *inode, struct file *filp)
 	struct kvm_device *dev = filp->private_data;
 	struct kvm *kvm = dev->kvm;
 
-	if (!dev)
-		return -ENODEV;
-
-	if (dev->kvm != kvm)
-		return -EPERM;
-
 	if (dev->ops->release) {
 		mutex_lock(&kvm->lock);
 		list_del(&dev->vm_node);