From: Jérôme Pouiller Date: Tue, 8 Oct 2019 09:42:59 +0000 (+0000) Subject: staging: wfx: remove misused call to cpu_to_le16() X-Git-Tag: v5.5-rc1~135^2~309 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=488d349061fa0ae61d5a50118e7d9cf2d28f03b5;p=users%2Fjedix%2Flinux-maple.git staging: wfx: remove misused call to cpu_to_le16() Indeed, hif_msg->id is a uint8_t, so use of cpu_to_le16() is a madness. Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames") Reported-by: kbuild test robot Reported-by: Stephen Rothwell Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20191008094232.10014-3-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 7f2799fbdafe1..1891bcaaf9fcf 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -620,7 +620,7 @@ static int wfx_tx_inner(struct wfx_vif *wvif, struct ieee80211_sta *sta, struct memset(skb->data, 0, wmsg_len); hif_msg = (struct hif_msg *) skb->data; hif_msg->len = cpu_to_le16(skb->len); - hif_msg->id = cpu_to_le16(HIF_REQ_ID_TX); + hif_msg->id = HIF_REQ_ID_TX; hif_msg->interface = wvif->id; if (skb->len > wvif->wdev->hw_caps.size_inp_ch_buf) { dev_warn(wvif->wdev->dev, "requested frame size (%d) is larger than maximum supported (%d)\n",