From: Andy Shevchenko Date: Thu, 19 Oct 2023 17:34:55 +0000 (+0300) Subject: gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data() X-Git-Tag: nvme-6.7-2023-11-22~199^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=479ac419206b5fe4ce4e40de61ac3210a36711aa;p=nvme.git gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data() When refactoring the acpi_get_gpiod_from_data() the change missed cleaning up the variable on stack. Add missing memset(). Reported-by: Ferry Toth Fixes: 16ba046e86e9 ("gpiolib: acpi: teach acpi_find_gpio() to handle data-only nodes") Signed-off-by: Andy Shevchenko Reviewed-by: Dmitry Torokhov Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index fbda452fb4d6..51e41676de0b 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -951,6 +951,7 @@ static struct gpio_desc *acpi_get_gpiod_from_data(struct fwnode_handle *fwnode, if (!propname) return ERR_PTR(-EINVAL); + memset(&lookup, 0, sizeof(lookup)); lookup.index = index; ret = acpi_gpio_property_lookup(fwnode, propname, index, &lookup);