From: Daniel Lenski <dlenski@gmail.com>
Date: Sat, 6 Oct 2018 04:36:38 +0000 (-0700)
Subject: Don't segfault when search domain list is empty (and thus `domains->pos == 0`)
X-Git-Tag: v8.00~69^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=474620818813e38bc29738ac8b1f0da668499722;p=users%2Fdwmw2%2Fopenconnect.git

Don't segfault when search domain list is empty (and thus `domains->pos == 0`)

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
---

diff --git a/gpst.c b/gpst.c
index d0fb0b3b..cae4e4f8 100644
--- a/gpst.c
+++ b/gpst.c
@@ -509,7 +509,7 @@ static int gpst_parse_config_xml(struct openconnect_info *vpninfo, xmlNode *xml_
 			for (member = xml_node->children; member; member=member->next)
 				if (!xmlnode_get_val(member, "member", &s))
 					buf_append(domains, "%s ", s);
-			if (buf_error(domains) == 0) {
+			if (buf_error(domains) == 0 && domains->pos > 0) {
 				domains->data[domains->pos-1] = '\0';
 				vpninfo->ip_info.domain = add_option(vpninfo, "search", &domains->data);
 			}