From: Danilo Krummrich Date: Mon, 28 Apr 2025 14:00:27 +0000 (+0200) Subject: rust: revocable: implement Revocable::access() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=46f91addfabbd4109fb64876a032ae4a4a924919;p=users%2Fjedix%2Flinux-maple.git rust: revocable: implement Revocable::access() Implement an unsafe direct accessor for the data stored within the Revocable. This is useful for cases where we can prove that the data stored within the Revocable is not and cannot be revoked for the duration of the lifetime of the returned reference. Reviewed-by: Christian Schrefl Reviewed-by: Benno Lossin Acked-by: Miguel Ojeda Reviewed-by: Alexandre Courbot Acked-by: Boqun Feng Reviewed-by: Joel Fernandes Link: https://lore.kernel.org/r/20250428140137.468709-2-dakr@kernel.org Signed-off-by: Danilo Krummrich --- diff --git a/rust/kernel/revocable.rs b/rust/kernel/revocable.rs index 971d0dc38d83d..db4aa46bb1216 100644 --- a/rust/kernel/revocable.rs +++ b/rust/kernel/revocable.rs @@ -139,6 +139,18 @@ impl Revocable { self.try_access().map(|t| f(&*t)) } + /// Directly access the revocable wrapped object. + /// + /// # Safety + /// + /// The caller must ensure this [`Revocable`] instance hasn't been revoked and won't be revoked + /// as long as the returned `&T` lives. + pub unsafe fn access(&self) -> &T { + // SAFETY: By the safety requirement of this function it is guaranteed that + // `self.data.get()` is a valid pointer to an instance of `T`. + unsafe { &*self.data.get() } + } + /// # Safety /// /// Callers must ensure that there are no more concurrent users of the revocable object.