From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 12 Sep 2025 19:07:16 +0000 (+0200)
Subject: net: phylink: warn if deprecated array-style fixed-link binding is used
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4689a42904299d054e59fc9d59e8e00884ffcf87;p=users%2Fhch%2Fmisc.git

net: phylink: warn if deprecated array-style fixed-link binding is used

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/cc823d38-2a2c-4c83-9a27-d7f25d61a2de@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 1988b7d2089a..1b06805f1bd7 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -702,6 +702,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
 			return -EINVAL;
 		}
 
+		phylink_warn(pl, "%pfw uses deprecated array-style fixed-link binding!\n",
+			     fwnode);
+
 		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
 						     prop, ARRAY_SIZE(prop));
 		if (!ret) {