From: Ilpo Järvinen Date: Fri, 29 Aug 2025 13:11:13 +0000 (+0300) Subject: PCI: Alter misleading recursion to pci_bus_release_bridge_resources() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=43b4f7cd064b2ae11742f33e2af195adae00c617;p=users%2Fhch%2Fmisc.git PCI: Alter misleading recursion to pci_bus_release_bridge_resources() Recursing into pci_bus_release_bridge_resources() should not alter rel_type because it makes no sense to change the release type within the recursion call chain. A literal "whole_subtree" is passed into the recursion instead of "rel_type" parameter which is misleading as the release type should remain the same throughout the entire operation. This is not a correctness issue because of the preceding if () that only allows the recursion to happen if rel_type is "whole_subtree". Still, replace the non-intuitive parameter with direct passing of "rel_type". Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas Link: https://patch.msgid.link/20250829131113.36754-25-ilpo.jarvinen@linux.intel.com --- diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 4ce747b5dea3..d264f16772b9 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -1855,7 +1855,7 @@ static void pci_bus_release_bridge_resources(struct pci_bus *bus, if (res->parent != b_win) continue; - pci_bus_release_bridge_resources(b, res, whole_subtree); + pci_bus_release_bridge_resources(b, res, rel_type); } }