From: leixiang Date: Tue, 27 Dec 2022 08:16:04 +0000 (+0800) Subject: virtio-pci: fix proxy->vector_irqfd leak in virtio_pci_set_guest_notifiers X-Git-Tag: xenpvh-tag~49^2~8 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4396d4bd74ade31f4de9357dca3d87409280c4ac;p=users%2Fdwmw2%2Fqemu.git virtio-pci: fix proxy->vector_irqfd leak in virtio_pci_set_guest_notifiers proxy->vector_irqfd did not free when kvm_virtio_pci_vector_use or msix_set_vector_notifiers failed in virtio_pci_set_guest_notifiers. Fixes: 7d37d351 Signed-off-by: Lei Xiang Tested-by: Zeng Chi Suggested-by: Xie Ming Message-Id: <20221227081604.806415-1-leixiang@kylinos.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 7bc60fcf94..247325c193 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1291,6 +1291,8 @@ assign_error: while (--n >= 0) { virtio_pci_set_guest_notifier(d, n, !assign, with_irqfd); } + g_free(proxy->vector_irqfd); + proxy->vector_irqfd = NULL; return r; }