From: Miaohe Lin Date: Tue, 19 Jul 2022 11:52:33 +0000 (+0800) Subject: mm/mempolicy: remove unneeded out label X-Git-Tag: howlett/maple/20220722_2~8 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=435e21775cc81e33ce60a83fcde37be8f83a512b;p=users%2Fjedix%2Flinux-maple.git mm/mempolicy: remove unneeded out label We can use unlock label to unlock ptl and return ret directly to remove the unneeded out label and reduce the size of mempolicy.o. No functional change intended. [Before] text data bss dec hex filename 26702 3972 6168 36842 8fea mm/mempolicy.o [After] text data bss dec hex filename 26662 3972 6168 36802 8fc2 mm/mempolicy.o Link: https://lkml.kernel.org/r/20220719115233.6706-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Signed-off-by: Andrew Morton --- diff --git a/mm/mempolicy.c b/mm/mempolicy.c index dc74239d1ac77..6c27acb6cd63d 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -466,9 +466,8 @@ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr, } page = pmd_page(*pmd); if (is_huge_zero_page(page)) { - spin_unlock(ptl); walk->action = ACTION_CONTINUE; - goto out; + goto unlock; } if (!queue_pages_required(page, qp)) goto unlock; @@ -485,7 +484,6 @@ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr, ret = -EIO; unlock: spin_unlock(ptl); -out: return ret; }