From: David Heidelberg <david@ixit.cz>
Date: Wed, 2 Apr 2025 19:33:24 +0000 (+0200)
Subject: iio: light: al3010: Improve al3010_init error handling with dev_err_probe()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=42b1a2663f4b7630f3a2793969f9c8f2ff451db4;p=users%2Fjedix%2Flinux-maple.git

iio: light: al3010: Improve al3010_init error handling with dev_err_probe()

Minor code simplifications and improved error reporting.

Signed-off-by: David Heidelberg <david@ixit.cz>
Link: https://patch.msgid.link/20250402-al3010-iio-regmap-v4-1-d189bea87261@ixit.cz
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
index 8c004a9239aef..a4116763c2296 100644
--- a/drivers/iio/light/al3010.c
+++ b/drivers/iio/light/al3010.c
@@ -92,7 +92,7 @@ static int al3010_init(struct al3010_data *data)
 	ret = devm_add_action_or_reset(&data->client->dev,
 				       al3010_set_pwr_off,
 				       data);
-	if (ret < 0)
+	if (ret)
 		return ret;
 
 	ret = i2c_smbus_write_byte_data(data->client, AL3010_REG_CONFIG,
@@ -190,10 +190,8 @@ static int al3010_probe(struct i2c_client *client)
 	indio_dev->modes = INDIO_DIRECT_MODE;
 
 	ret = al3010_init(data);
-	if (ret < 0) {
-		dev_err(dev, "al3010 chip init failed\n");
-		return ret;
-	}
+	if (ret)
+		return dev_err_probe(dev, ret, "failed to init ALS\n");
 
 	return devm_iio_device_register(dev, indio_dev);
 }