From: Vladimir Oltean Date: Sat, 9 Jan 2021 00:01:54 +0000 (+0200) Subject: net: dsa: remove obsolete comments about switchdev transactions X-Git-Tag: howlett/maple/20220722_2~3823^2~371^2~2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=417b99bf75c329e3d13555c720e621158c164b71;p=users%2Fjedix%2Flinux-maple.git net: dsa: remove obsolete comments about switchdev transactions Now that all port object notifiers were converted to be non-transactional, we can remove the comments that say otherwise. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Acked-by: Linus Walleij Acked-by: Jiri Pirko Signed-off-by: Jakub Kicinski --- diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 7ba505825db2..5d7f6cada6a8 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev, struct dsa_port *dp = dsa_slave_to_port(dev); int err; - /* For the prepare phase, ensure the full set of changes is feasable in - * one go in order to signal a failure properly. If an operation is not - * supported, return -EOPNOTSUPP. - */ - switch (obj->id) { case SWITCHDEV_OBJ_ID_PORT_MDB: if (obj->orig_dev != dev) diff --git a/net/dsa/switch.c b/net/dsa/switch.c index f92eaacb17cf..21d2f842d068 100644 --- a/net/dsa/switch.c +++ b/net/dsa/switch.c @@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb, break; } - /* Non-switchdev operations cannot be rolled back. If a DSA driver - * returns an error during the chained call, switch chips may be in an - * inconsistent state. - */ if (err) dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n", event, err);