From: Eric Biggers Date: Wed, 5 Mar 2025 01:58:30 +0000 (-0800) Subject: lib/crc_kunit.c: update comment in crc_benchmark() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=415999ea30015681d2ba32e78cb651d23d33cb53;p=users%2Fwilly%2Fxarray.git lib/crc_kunit.c: update comment in crc_benchmark() None of the CRC library functions use __pure anymore, so the comment in crc_benchmark() is outdated. But the comment was not really correct anyway, since the CRC computation could (in principle) be optimized out regardless of __pure. Update the comment to have a proper explanation. Link: https://lore.kernel.org/r/20250305015830.37813-1-ebiggers@kernel.org Signed-off-by: Eric Biggers --- diff --git a/lib/crc_kunit.c b/lib/crc_kunit.c index 0e15eb244b20..585c48b65cef 100644 --- a/lib/crc_kunit.c +++ b/lib/crc_kunit.c @@ -226,8 +226,9 @@ crc_benchmark(struct kunit *test, }; size_t len, i, j, num_iters; /* - * Some of the CRC library functions are marked as __pure, so use - * volatile to ensure that all calls are really made as intended. + * The CRC value that this function computes in a series of calls to + * crc_func is never actually used, so use volatile to ensure that the + * computations are done as intended and don't all get optimized out. */ volatile u64 crc = 0; u64 t;