From: Vasily Averin <vvs@virtuozzo.com>
Date: Wed, 7 Nov 2018 16:10:21 +0000 (-0500)
Subject: ext4: fix buffer leak in ext4_xattr_move_to_block() on error path
X-Git-Tag: v4.14.82~37
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=4096fc0912778196f04d66fef5189a897dba0131;p=users%2Fjedix%2Flinux-maple.git

ext4: fix buffer leak in ext4_xattr_move_to_block() on error path

commit 6bdc9977fcdedf47118d2caf7270a19f4b6d8a8f upstream.

Fixes: 3f2571c1f91f ("ext4: factor out xattr moving")
Fixes: 6dd4ee7cab7e ("ext4: Expand extra_inodes space per ...")
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 2.6.23
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 49b3d9b038e0..da46b5162937 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2626,6 +2626,8 @@ out:
 	kfree(buffer);
 	if (is)
 		brelse(is->iloc.bh);
+	if (bs)
+		brelse(bs->bh);
 	kfree(is);
 	kfree(bs);