From: Martin George <marting@netapp.com>
Date: Sun, 9 Feb 2025 18:42:28 +0000 (+0530)
Subject: nvme-print-stdout: add details in list-ns verbose output
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3f3c4ff7c25e84ca9315dd69743c35dc786e5d88;p=users%2Fsagi%2Fnvme-cli.git

nvme-print-stdout: add details in list-ns verbose output

Add identifier & NSID tags in the verbose output of the list-ns
command for better clarity. And while at it, print a common
"NVMe Namespace List" tag at the top too. For e.g.

nvme list-ns /dev/nvme1n1 -v
dev: /dev/nvme1n1, fd: 3
NVME Namespace List:
Identifier    0: NSID 0x1
Identifier    1: NSID 0x2
...

Signed-off-by: Martin George <marting@netapp.com>
---

diff --git a/nvme-print-stdout.c b/nvme-print-stdout.c
index 5c0eee9d..c8e2ea65 100644
--- a/nvme-print-stdout.c
+++ b/nvme-print-stdout.c
@@ -3640,11 +3640,18 @@ static void stdout_zns_id_ns(struct nvme_zns_id_ns *ns,
 
 static void stdout_list_ns(struct nvme_ns_list *ns_list)
 {
-	int i;
+	int i, verbose = stdout_print_ops.flags & VERBOSE;
 
+	printf("NVME Namespace List:\n");
 	for (i = 0; i < 1024; i++) {
-		if (ns_list->ns[i])
-			printf("[%4u]:%#x\n", i, le32_to_cpu(ns_list->ns[i]));
+		if (ns_list->ns[i]) {
+			if (verbose)
+				printf("Identifier %4u: NSID %#x\n",
+						i, le32_to_cpu(ns_list->ns[i]));
+			else
+				printf("[%4u]:%#x\n",
+						i, le32_to_cpu(ns_list->ns[i]));
+		}
 	}
 }
 
diff --git a/nvme.c b/nvme.c
index a50ffab6..1f46cd55 100644
--- a/nvme.c
+++ b/nvme.c
@@ -2716,6 +2716,9 @@ static int list_ns(int argc, char **argv, struct command *cmd, struct plugin *pl
 		return -EINVAL;
 	}
 
+	if (argconfig_parse_seen(opts, "verbose"))
+		flags |= VERBOSE;
+
 	ns_list = nvme_alloc(sizeof(*ns_list));
 	if (!ns_list)
 		return -ENOMEM;