From: Andre Edich Date: Mon, 6 Jul 2020 08:39:35 +0000 (+0200) Subject: smsc95xx: avoid memory leak in smsc95xx_bind X-Git-Tag: v5.8-rc5~11^2~32^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3ed58f96a70b85ef646d5427258f677f1395b62f;p=users%2Fdwmw2%2Flinux.git smsc95xx: avoid memory leak in smsc95xx_bind In a case where the ID_REV register read is failed, the memory for a private data structure has to be freed before returning error from the function smsc95xx_bind. Fixes: bbd9f9ee69242 ("smsc95xx: add wol support for more frame types") Signed-off-by: Andre Edich Signed-off-by: Parthiban Veerasooran Signed-off-by: David S. Miller --- diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index eb404bb74e18e..bb4ccbda031ab 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1293,7 +1293,8 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) /* detect device revision as different features may be available */ ret = smsc95xx_read_reg(dev, ID_REV, &val); if (ret < 0) - return ret; + goto free_pdata; + val >>= 16; pdata->chip_id = val; pdata->mdix_ctrl = get_mdix_status(dev->net);