From: Advait Dhamorikar Date: Mon, 7 Oct 2024 15:23:34 +0000 (+0530) Subject: smb/client: Fix logically dead code X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3dfea293f4279b3021cb0ecf3807e763bddb63b9;p=users%2Fjedix%2Flinux-maple.git smb/client: Fix logically dead code The if condition in collect_sample: can never be satisfied because of a logical contradiction. The indicated dead code may have performed some action; that action will never occur. Fixes: 94ae8c3fee94 ("smb: client: compress: LZ77 code improvements cleanup") Signed-off-by: Advait Dhamorikar Signed-off-by: Steve French --- diff --git a/fs/smb/client/compress.c b/fs/smb/client/compress.c index 63b5a55b7a575..766b4de13da76 100644 --- a/fs/smb/client/compress.c +++ b/fs/smb/client/compress.c @@ -166,7 +166,6 @@ static int collect_sample(const struct iov_iter *iter, ssize_t max, u8 *sample) loff_t start = iter->xarray_start + iter->iov_offset; pgoff_t last, index = start / PAGE_SIZE; size_t len, off, foff; - ssize_t ret = 0; void *p; int s = 0; @@ -193,9 +192,6 @@ static int collect_sample(const struct iov_iter *iter, ssize_t max, u8 *sample) memcpy(&sample[s], p, len2); kunmap_local(p); - if (ret < 0) - return ret; - s += len2; if (len2 < SZ_2K || s >= max - SZ_2K)