From: Shiju Jose <shiju.jose@huawei.com>
Date: Wed, 16 Oct 2019 16:33:57 +0000 (+0100)
Subject: rasdaemon: fix missing fclose in ras-events.c:select_tracing_timestamp()
X-Git-Tag: v0.6.5~7
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3dc829fa56a94716d2f3b47944491a724825d014;p=users%2Fmchehab%2Frasdaemon.git

rasdaemon: fix missing fclose in ras-events.c:select_tracing_timestamp()

This patch adds fix for missing fclose() in select_tracing_timestamp()
when return fail if can't parse /proc/uptime.

Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/ras-events.c b/ras-events.c
index d543251..fc6b288 100644
--- a/ras-events.c
+++ b/ras-events.c
@@ -600,12 +600,12 @@ static int select_tracing_timestamp(struct ras_events *ras)
 		return 0;
 	}
 	rc = fscanf(fp, "%zu.%u ", &uptime, &j1);
+	fclose(fp);
 	if (rc <= 0) {
 		log(TERM, LOG_ERR, "Can't parse /proc/uptime!\n");
 		return -1;
 	}
 	now = time(NULL);
-	fclose(fp);
 
 	ras->use_uptime = 1;
 	ras->uptime_diff = now - uptime;