From: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
Date: Wed, 22 Sep 2021 13:40:22 +0000 (+0200)
Subject: Avoid code complexity
X-Git-Tag: v9.00~62^2~6
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3c7c60ef99b13250011d98d33ee21968c6ab6fd6;p=users%2Fdwmw2%2Fopenconnect.git

Avoid code complexity

This fixes a CodeClimate alert.

Found and removed a duplicate test in the process.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
---

diff --git a/www/html.py b/www/html.py
index 21c46149..ea9e9f91 100755
--- a/www/html.py
+++ b/www/html.py
@@ -142,23 +142,10 @@ class docHandler(xml.sax.ContentHandler):
 
     def endElement(self, name):
 
-        if name == "PAGE":
-            return
-        elif name == 'INCLUDE':
-            return
-        elif name == 'PARSE':
-            return
-        elif name == 'PAGE':
-            return
-        elif name == 'STARTMENU':
-            return
-        elif name == 'ENDMENU':
-            return
-        elif name == 'MENU':
-            return
-        elif name == 'VAR':
-            return
-        elif name == 'br':
+        if name in {
+            "PAGE", "INCLUDE", "PARSE", "STARTMENU", "ENDMENU", "MENU",
+            "VAR", "br",
+        }:
             return
 
         if len(self.content) > 0: