From: Michal Wajdeczko Date: Thu, 31 Jul 2025 19:33:35 +0000 (+0200) Subject: drm/xe/configfs: Reintroduce struct xe_config_device X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3c643f6216215c7e4e30f7a647024a20847b27af;p=users%2Fjedix%2Flinux-maple.git drm/xe/configfs: Reintroduce struct xe_config_device This time it will hold just pure configuration parameters, without any configfs related stuff. This will help us define defaults data without wasting space for unneeded data. Signed-off-by: Michal Wajdeczko Reviewed-by: John Harrison Reviewed-by: Lucas De Marchi Link: https://lore.kernel.org/r/20250731193339.179829-8-michal.wajdeczko@intel.com Signed-off-by: Lucas De Marchi --- diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c index acdee616d118..7ad9fc65e21d 100644 --- a/drivers/gpu/drm/xe/xe_configfs.c +++ b/drivers/gpu/drm/xe/xe_configfs.c @@ -88,8 +88,10 @@ struct xe_config_group_device { struct config_group group; - bool survivability_mode; - u64 engines_allowed; + struct xe_config_device { + bool survivability_mode; + u64 engines_allowed; + } config; /* protects attributes */ struct mutex lock; @@ -118,9 +120,14 @@ static struct xe_config_group_device *to_xe_config_group_device(struct config_it return container_of(to_config_group(item), struct xe_config_group_device, group); } +static struct xe_config_device *to_xe_config_device(struct config_item *item) +{ + return &to_xe_config_group_device(item)->config; +} + static ssize_t survivability_mode_show(struct config_item *item, char *page) { - struct xe_config_group_device *dev = to_xe_config_group_device(item); + struct xe_config_device *dev = to_xe_config_device(item); return sprintf(page, "%d\n", dev->survivability_mode); } @@ -136,7 +143,7 @@ static ssize_t survivability_mode_store(struct config_item *item, const char *pa return ret; mutex_lock(&dev->lock); - dev->survivability_mode = survivability_mode; + dev->config.survivability_mode = survivability_mode; mutex_unlock(&dev->lock); return len; @@ -144,7 +151,7 @@ static ssize_t survivability_mode_store(struct config_item *item, const char *pa static ssize_t engines_allowed_show(struct config_item *item, char *page) { - struct xe_config_group_device *dev = to_xe_config_group_device(item); + struct xe_config_device *dev = to_xe_config_device(item); char *p = page; for (size_t i = 0; i < ARRAY_SIZE(engine_info); i++) { @@ -220,7 +227,7 @@ static ssize_t engines_allowed_store(struct config_item *item, const char *page, } mutex_lock(&dev->lock); - dev->engines_allowed = val; + dev->config.engines_allowed = val; mutex_unlock(&dev->lock); return len; @@ -282,7 +289,7 @@ static struct config_group *xe_config_make_device_group(struct config_group *gro return ERR_PTR(-ENOMEM); /* Default values */ - dev->engines_allowed = U64_MAX; + dev->config.engines_allowed = U64_MAX; config_group_init_type_name(&dev->group, name, &xe_config_device_type); @@ -340,7 +347,7 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) if (!dev) return false; - mode = dev->survivability_mode; + mode = dev->config.survivability_mode; config_group_put(&dev->group); return mode; @@ -361,7 +368,7 @@ void xe_configfs_clear_survivability_mode(struct pci_dev *pdev) return; mutex_lock(&dev->lock); - dev->survivability_mode = 0; + dev->config.survivability_mode = 0; mutex_unlock(&dev->lock); config_group_put(&dev->group); @@ -384,7 +391,7 @@ u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) if (!dev) return U64_MAX; - engines_allowed = dev->engines_allowed; + engines_allowed = dev->config.engines_allowed; config_group_put(&dev->group); return engines_allowed;