From: Cleber Rosa Date: Thu, 11 Feb 2021 22:01:41 +0000 (-0500) Subject: Python: close the log file kept by QEMUMachine before reading it X-Git-Tag: v6.0.0-rc0~84^2~6 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3c1e16c60c72e8f11a15d63e9d4a2fd33be6b106;p=users%2Fdwmw2%2Fqemu.git Python: close the log file kept by QEMUMachine before reading it Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the content will be flushed. Reference: https://docs.python.org/3/library/io.html#io.IOBase.close Signed-off-by: Cleber Rosa Message-Id: <20210211220146.2525771-2-crosa@redhat.com> Reviewed-by: John Snow Signed-off-by: Cleber Rosa --- diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 7a40f4604b..6e44bda337 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -337,12 +337,12 @@ class QEMUMachine: self._qmp.close() self._qmp_connection = None - self._load_io_log() - if self._qemu_log_file is not None: self._qemu_log_file.close() self._qemu_log_file = None + self._load_io_log() + self._qemu_log_path = None if self._temp_dir is not None: