From: Damien Le Moal Date: Tue, 1 Jul 2025 12:53:20 +0000 (+0900) Subject: ata: libata-core: Reduce the number of messages signaling broken LPM X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3b50dd4c064d71f8f50a266b46d93537eeba782e;p=users%2Fjedix%2Flinux-maple.git ata: libata-core: Reduce the number of messages signaling broken LPM ata_dev_config_lpm() prints the message "LPM support broken, forcing max_power" for devices that have the ATA_QUIRK_NOLPM quirk flag set. This messages is repeated for every device revalidation, which is not necessary, but also erroneously printed for devices without a broken LPM support when connected to a port that does not support LPM (e.g. because the port is an external one with hotplug capability). Since in all cases the device port target_lpm_policy is set to ATA_LPM_MAX_POWER, avoid the "LPM broken" message repetition and erroneous output by generating it only if the port target_lpm_policy is not already set to ATA_LPM_MAX_POWER. This change will suppress the "LPM broken" message for genuine cases of a device having broken LPM if the initial LPM policy is set to ATA_LPM_MAX_POWER through CONFIG_SATA_MOBILE_LPM_POLICY. This is not a problem as the ATA_LPM_MAX_POWER policy implies that LPM is disabled and unused, which is safe for devices with broken LPM. Signed-off-by: Damien Le Moal Reviewed-by: Niklas Cassel Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20250701125321.69496-10-dlemoal@kernel.org Signed-off-by: Niklas Cassel --- diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 4619e66ae100c..7f6cebe61b337 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2819,7 +2819,8 @@ static void ata_dev_config_lpm(struct ata_device *dev) dev->quirks |= ATA_QUIRK_NOLPM; } - if (dev->quirks & ATA_QUIRK_NOLPM) { + if (dev->quirks & ATA_QUIRK_NOLPM && + ap->target_lpm_policy != ATA_LPM_MAX_POWER) { ata_dev_warn(dev, "LPM support broken, forcing max_power\n"); ap->target_lpm_policy = ATA_LPM_MAX_POWER; }