From: Dan Carpenter Date: Tue, 18 Feb 2025 13:05:50 +0000 (+0300) Subject: media: i2c: imx214: Fix uninitialized variable in imx214_set_ctrl() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=38985a25682c66d1a7599b0e95ceeb9c7ba89f84;p=users%2Fjedix%2Flinux-maple.git media: i2c: imx214: Fix uninitialized variable in imx214_set_ctrl() You can't pass uninitialized "ret" variables to cci_write(). It has to start as zero. Fixes: 4f0aeba4f155 ("media: i2c: imx214: Convert to CCI register access helpers") Signed-off-by: Dan Carpenter Reviewed-by: André Apitzsch Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 4f320660c91c4..dd7bc45523d8b 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -795,7 +795,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl *ctrl) struct imx214, ctrls); const struct v4l2_mbus_framefmt *format = NULL; struct v4l2_subdev_state *state; - int ret; + int ret = 0; if (ctrl->id == V4L2_CID_VBLANK) { int exposure_max, exposure_def;