From: Zhang Changzhong Date: Fri, 13 Nov 2020 06:49:33 +0000 (+0800) Subject: net: ethernet: ti: cpsw: fix error return code in cpsw_probe() X-Git-Tag: howlett/maple_spf/20210104~526^2~32 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=35f735c665114840dcd3142f41148d07870f51f7;p=users%2Fjedix%2Flinux-maple.git net: ethernet: ti: cpsw: fix error return code in cpsw_probe() Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong Link: https://lore.kernel.org/r/1605250173-18438-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index fa2d1025cbb2a..b0f00b4edd949 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1634,6 +1634,7 @@ static int cpsw_probe(struct platform_device *pdev) CPSW_MAX_QUEUES, CPSW_MAX_QUEUES); if (!ndev) { dev_err(dev, "error allocating net_device\n"); + ret = -ENOMEM; goto clean_cpts; }