From: Chandra Mohan Sundar Date: Mon, 1 Sep 2025 16:29:19 +0000 (+0530) Subject: net: macb: Validate the value of base_time properly X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3586018d5c3da14addcd033b6da5a1a209a0992d;p=users%2Fhch%2Fmisc.git net: macb: Validate the value of base_time properly In macb_taprio_setup_replace(), the value of start_time is being compared against zero which would never be true since start_time is an unsigned value. Due to this there is a chance that an incorrect config base time value can be used for computation. Fix by checking the value of conf->base_time directly. This issue was reported by static coverity analyzer. Fixes: 89934dbf169e3 ("net: macb: Add TAPRIO traffic scheduling support") Signed-off-by: Chandra Mohan Sundar Reviewed-by: Vineeth Karumanchi Link: https://patch.msgid.link/20250901162923.627765-1-chandramohan.explore@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 290d67da704d..e9b262a0223f 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4104,7 +4104,7 @@ static int macb_taprio_setup_replace(struct net_device *ndev, return -EINVAL; } - if (start_time < 0) { + if (conf->base_time < 0) { netdev_err(ndev, "Invalid base_time: must be 0 or positive, got %lld\n", conf->base_time); return -ERANGE;