From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 3 Aug 2016 19:01:07 +0000 (+0300)
Subject: i40e: remove a stray unlock
X-Git-Tag: v4.1.12-98.0.20170517_2143~42^2~205
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=352be23d1bd094bd987c065f5eec4a5912db855e;p=users%2Fjedix%2Flinux-maple.git

i40e: remove a stray unlock

Orabug: 24568124

We shifted the locking around a bit but forgot to delete this unlock so
now it can unlock twice.

Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit be0cb0a66a1d426f7cd9b170c008725044ae147a)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
---

diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index 0bf90b34c6d1f..2af0811012bd9 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -992,7 +992,6 @@ int i40e_unregister_client(struct i40e_client *client)
 	if (!i40e_client_is_registered(client)) {
 		pr_info("i40e: Client %s has not been registered\n",
 			client->name);
-		mutex_unlock(&i40e_client_mutex);
 		ret = -ENODEV;
 		goto out;
 	}