From: Zhang Xiaoxu Date: Sat, 20 Jun 2020 02:51:29 +0000 (-0400) Subject: cifs: update ctime and mtime during truncate X-Git-Tag: v4.14.189~114 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=34a71f641f0b6ff78c3a3b58238958566af0cfe2;p=users%2Fdwmw2%2Flinux.git cifs: update ctime and mtime during truncate [ Upstream commit 5618303d8516f8ac5ecfe53ee8e8bc9a40eaf066 ] As the man description of the truncate, if the size changed, then the st_ctime and st_mtime fields should be updated. But in cifs, we doesn't do it. It lead the xfstests generic/313 failed. So, add the ATTR_MTIME|ATTR_CTIME flags on attrs when change the file size Reported-by: Hulk Robot Signed-off-by: Zhang Xiaoxu Signed-off-by: Steve French Signed-off-by: Sasha Levin --- diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 528fe225b65a9..d0d295a28b6e4 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -2216,6 +2216,15 @@ set_size_out: if (rc == 0) { cifsInode->server_eof = attrs->ia_size; cifs_setsize(inode, attrs->ia_size); + + /* + * The man page of truncate says if the size changed, + * then the st_ctime and st_mtime fields for the file + * are updated. + */ + attrs->ia_ctime = attrs->ia_mtime = current_time(inode); + attrs->ia_valid |= ATTR_CTIME | ATTR_MTIME; + cifs_truncate_page(inode->i_mapping, inode->i_size); }